Upgrade failed

phenomlab@community.nodebb.org

Hi. Trying to upgrade NodeBB to latest version, and get

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: nodebb@4.4.1
npm ERR! Found: eslint@8.57.1
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || &gt;=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@8.57.1
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@9.3.0
npm ERR!     node_modules/nodebb-plugin-sso-oauth2-multiple/node_modules/eslint
npm ERR!       eslint@"9.x" from nodebb-plugin-sso-oauth2-multiple@1.4.2
npm ERR!       node_modules/nodebb-plugin-sso-oauth2-multiple
npm ERR!         nodebb-plugin-sso-oauth2-multiple@"^1.4.2" from the root project
npm ERR!   peer eslint@"^7.32.0 || ^8.2.0" from eslint-config-airbnb-base@15.0.0
npm ERR!   node_modules/eslint-config-airbnb-base
npm ERR!     eslint-config-airbnb-base@"15.0.0" from eslint-config-nodebb@0.2.1
npm ERR!     node_modules/eslint-config-nodebb
npm ERR!       dev eslint-config-nodebb@"1.1.4" from the root project
npm ERR!       1 more (nodebb-plugin-gravatar)
npm ERR!   4 more (eslint-config-nodebb, eslint-plugin-import, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @stylistic/eslint-plugin-js@"4.2.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint@9.27.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"&gt;=9.0.0" from @stylistic/eslint-plugin-js@4.2.0
npm ERR!   node_modules/@stylistic/eslint-plugin-js
npm ERR!     dev @stylistic/eslint-plugin-js@"4.2.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

Any ideas?

Thanks

julian@community.nodebb.org

phenomlab can you delete your package-lock.json and try again?

phenomlab@community.nodebb.org

julian Done, but still fails - this time with a slightly different message

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: nodebb@4.4.1
npm ERR! Found: eslint@8.57.1
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || &gt;=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@8.57.1
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@9.3.0
npm ERR!     node_modules/nodebb-plugin-sso-oauth2-multiple/node_modules/eslint
npm ERR!       eslint@"9.x" from nodebb-plugin-sso-oauth2-multiple@1.4.2
npm ERR!       node_modules/nodebb-plugin-sso-oauth2-multiple
npm ERR!         nodebb-plugin-sso-oauth2-multiple@"^1.4.2" from the root project
npm ERR!   peer eslint@"^7.32.0 || ^8.2.0" from eslint-config-airbnb-base@15.0.0
npm ERR!   node_modules/eslint-config-airbnb-base
npm ERR!     eslint-config-airbnb-base@"15.0.0" from eslint-config-nodebb@0.2.1
npm ERR!     node_modules/eslint-config-nodebb
npm ERR!       dev eslint-config-nodebb@"1.1.4" from the root project
npm ERR!       1 more (nodebb-plugin-gravatar)
npm ERR!   4 more (eslint-config-nodebb, eslint-plugin-import, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @stylistic/eslint-plugin-js@"4.2.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint@9.27.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"&gt;=9.0.0" from @stylistic/eslint-plugin-js@4.2.0
npm ERR!   node_modules/@stylistic/eslint-plugin-js
npm ERR!     dev @stylistic/eslint-plugin-js@"4.2.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!

phenomlab@community.nodebb.org

RESOLVED: used npm update and then ./nodebb build

julian@community.nodebb.org

phenomlab ah good to hear, thanks, and sorry about that!

We’re not quite sure what happened with the eslint update that caused existing installs to complain so loudly.